linux-kernel - Re: [PATCH] dt-bindings: gpio: uniphier: Add hogs parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <81864a56-f48b-a41a-614b-16128f3850a9@socionext.com>
Date:   Tue, 29 Mar 2022 19:56:37 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: gpio: uniphier: Add hogs parsing

Hi Krzysztof,

On 2022/03/29 4:04, Krzysztof Kozlowski wrote:
> On 28/03/2022 03:28, Kunihiko Hayashi wrote:
>> Allow parsing GPIO controller children nodes with GPIO hogs to fix the
>> following warning:
>>
>>    uniphier-ld11-ref.dtb: gpio@...00000: 'xirq0-hog' does not match any of
>> the regexes: 'pinctrl-[0-9]+'
>>        From schema:
>> Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
>> ---
>>   .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml  | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>> b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>> index bcafa494ed7a..b6f5963a2ae6 100644
>> --- a/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>> +++ b/Documentation/devicetree/bindings/gpio/socionext,uniphier-gpio.yaml
>> @@ -52,6 +52,13 @@ properties:
>>         <child-interrupt-base parent-interrupt-base length> triplets.
>>       $ref: /schemas/types.yaml#/definitions/uint32-matrix
>>
>> +patternProperties:
>> +  "^(.+-hog(-[0-9]+)?)$":
> 
> The outer () are not needed.

Surely, the "()" can be removed.

>> +    type: object
> 
> You need also properties. See for example:
> Documentation/devicetree/bindings/gpio/fsl-imx-gpio.yaml

I see. I should list the valid properties in patternProperties.
I'll add it.

Thank you,

---
Best Regards
Kunihiko Hayashi