linux-kernel - Re: [PATCH] dt-bindings: serial: uniphier: Add "resets" property as optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <97bfd9cd-6b7c-1e93-e63b-f32764a6f317@socionext.com>
Date:   Tue, 29 Mar 2022 19:56:46 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        linux-serial@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: uniphier: Add "resets" property as
 optional

Hi Krzysztof,

On 2022/03/29 4:05, Krzysztof Kozlowski wrote:
> On 28/03/2022 03:26, Kunihiko Hayashi wrote:
>> UniPhier UART controller has a reset lines from system controller.
>> Add "resets" property to fix the following warning.
>>
>>    uniphier-ld11-global.dtb: serial@...06800: 'resets' does not match any
>> of the regexes: 'pinctrl-[0-9]+'
>>        From schema:
>> Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
>> ---
>>   .../devicetree/bindings/serial/socionext,uniphier-uart.yaml    | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
>> b/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
>> index d490c7c4b967..d14d8c9cfe4d 100644
>> ---
>> a/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
>> +++
>> b/Documentation/devicetree/bindings/serial/socionext,uniphier-uart.yaml
>> @@ -22,6 +22,9 @@ properties:
>>     clocks:
>>       minItems: 1
> 
> This should be fixed to maxItems as well (separate patch).

I see. In the case of one item, "maxItems" should be used.
I'll fix it in another patch.

>>
>> +  resets:
>> +    minItems: 1
> 
> maxItems

I'll fix it in this patch.

Thank you,

---
Best Regards
Kunihiko Hayashi