linux-kernel - Re: [PATCH RFC] dt-bindings: PCI: mediatek-gen3: Remove clock-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a1c70fd7-efe5-aacc-bb4f-74d7a21a310e@linaro.org>
Date:   Tue, 29 Mar 2022 19:14:58 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jianjun Wang <jianjun.wang@...iatek.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>
Cc:     Ryder Lee <ryder.lee@...iatek.com>, linux-pci@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        "allen-kh . cheng" <allen-kh.cheng@...iatek.com>
Subject: Re: [PATCH RFC] dt-bindings: PCI: mediatek-gen3: Remove clock-names

On 29/03/2022 09:15, Jianjun Wang wrote:
> Some SoC may have different clocks (e.g. MT8192 uses clock 'top_133m',
> but MT8195 use clock 'peri_mem' instead), since these clocks do not have
> any timing dependencies and the PCIe controller driver uses
> 'devm_clk_bulk_get_all' to gets all of them, remove 'clock-names' in
> dt-bindings file for compatible with different SoCs.

One driver behaves like this, other different. Driver implementation
might not be a reliable source. :)

The clock entries are expected to be ordered and fixed, so clock-names
should stay.

Best regards,
Krzysztof