linux-kernel - Re: [PATCH] thermal: exynos: fix masking value for artpec7 temp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <da21cafc-4e5e-cb5f-e7e5-ac9f223616a6@linaro.org>
Date:   Wed, 30 Mar 2022 19:05:42 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     hypmean.kim@...sung.com, "bzolnier@...il.com" <bzolnier@...il.com>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "amitk@...nel.org" <amitk@...nel.org>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>
Cc:     "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] thermal: exynos: fix masking value for artpec7 temp_error

On 30/03/2022 11:43, Sang Min Kim wrote:
> This patch is a modification related to masking of the temp_error value
> in the sanitize_temp_error() function.

Don't use "This patch" please.
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95

>  
> For SOC_ARCH_EXYNOS7, the temp_error1, 2 value should be masked as
> EXYNOS7_TMU_TEMP_MASK(0x1ff).
> The current code masks temp_error2 with EXYNOS_TMU_TEMP_MASK(0xff)
> value even in the case of EXYNOS7.
> In addition, when entering the if statement, both temp_error1 and 2
> are masked with EXYNOS_TMU_TEMP_MASK(0xff).
>  
> By modifying to use the previously declared local variable tmu_temp_mask,
> the mask value suitable for the SOC can be applied.
>  
> Signed-off-by: sangmin kim <hypmean.kim@...sung.com>

Fixes tag?

Code looks itself good, so with changes above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof