linux-kernel - Re: [PATCH] staging:rtl8723bs:rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Mar 2022 10:09:36 -0700
From:   Alison Schofield <alison.schofield@...el.com>
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
Cc:     outreachy@...ts.linux.dev, gregkh@...uxfoundation.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging:rtl8723bs:rtw_cmd.c remove suspect indent

On Wed, Mar 30, 2022 at 05:31:00PM +0200, Alaa Mohamed wrote:
> Fix "WARNING: suspect code indent for conditional
> statements (16, 32)" for line 1240
> founded by checkpatch.pl
> 
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>

Hi Alaa,

https://kernelnewbies.org/PatchPhilosophy
Please take a look at the section on "Patch subject formatting" 
and the follow on sections about checkpatch descriptions.

Thanks,
Alison


> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index 14d37b369273..46e18a90529f 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1238,7 +1238,7 @@ u8 traffic_status_watchdog(struct adapter *padapter, u8 from_timer)
>  		/*&& !MgntInitAdapterInProgress(pMgntInfo)*/) {
>  		/*  if we raise bBusyTraffic in last watchdog, using lower threshold. */
>  		if (pmlmepriv->LinkDetectInfo.bBusyTraffic)
> -				BusyThreshold = BusyThresholdLow;
> +			BusyThreshold = BusyThresholdLow;
>  
>  		if (pmlmepriv->LinkDetectInfo.NumRxOkInPeriod > BusyThreshold ||
>  			pmlmepriv->LinkDetectInfo.NumTxOkInPeriod > BusyThreshold) {
> -- 
> 2.35.1
> 
>