linux-kernel - Re: [PATCH] zram_drv: add __GFP_NOWARN flag on call to zs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkQXx+pLr6FxY1XZ@google.com>
Date:   Wed, 30 Mar 2022 17:41:43 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Michal Hocko <mhocko@...e.com>
Cc:     Jaewon Kim <jaewon31.kim@...sung.com>, minchan@...nel.org,
        ngupta@...are.org, senozhatsky@...omium.org,
        akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, s.suk@...sung.com,
        jaewon31.kim@...il.com
Subject: Re: [PATCH] zram_drv: add __GFP_NOWARN flag on call to zs_malloc

On (22/03/30 10:06), Michal Hocko wrote:
> On Wed 30-03-22 14:25:02, Jaewon Kim wrote:
> > The page allocation with GFP_NOIO may fail. And zram can handle this
> > allocation failure. We do not need to print log for this.
> 
> GFP_NOIO doesn't have any special meaning wrt to failures. zram
> allocates from the memory reclaim context which is a bad design IMHO.

Agreed.

> Is the memory allocation failure gracefully recoverable?

No, it's not. I agree that we want to see that allocation warning
in the logs.