linux-kernel - Re: [PATCH 1/2] arm64: mm: Do not defer reserve_crashkernel() if only ZONE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Mar 2022 20:37:01 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     Vijay Balakrishna <vijayb@...ux.microsoft.com>,
        Pasha Tatashin <pasha.tatashin@...een.com>
Subject: Re: [PATCH 1/2] arm64: mm: Do not defer reserve_crashkernel() if only
 ZONE_DMA32



On 3/24/2022 10:53 PM, Kefeng Wang wrote:
> The kernel could be benifit due to BLOCK_MAPPINGS, see commit
> 031495635b46 ("arm64: Do not defer reserve_crashkernel() for
> platforms with no DMA memory zones"), if there is only with
> ZONE_DMA32, we could set arm64_dma_phys_limit to max_zone_phys(32)
> earlier in arm64_memblock_init(), then we will benifit too.
> 
> Cc: Vijay Balakrishna <vijayb@...ux.microsoft.com>
> Cc: Pasha Tatashin <pasha.tatashin@...een.com>
> Cc: Will Deacon <will@...nel.org>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>   arch/arm64/mm/init.c | 18 ++++++++++--------
>   arch/arm64/mm/mmu.c  |  6 ++----
>   2 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c
> index 8ac25f19084e..9dded8779d72 100644
> --- a/arch/arm64/mm/init.c
> +++ b/arch/arm64/mm/init.c
> @@ -157,14 +157,14 @@ static phys_addr_t __init max_zone_phys(unsigned int zone_bits)
>   	return min(zone_mask, memblock_end_of_DRAM() - 1) + 1;
>   }
>   
> +phys_addr_t __ro_after_init dma32_phys_limit;

This variable should still be scoped to this file, it is not used 
outside of arch/arm64/mm/init.c.
-- 
Florian