linux-kernel - RE: [PATCH 05/22] acpica: Replace comments with C99 initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 31 Mar 2022 19:27:29 +0000
From:   "Moore, Robert" <robert.moore@...el.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Benjamin Stürz <benni@...erz.xyz>
CC:     Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        "linux@...tec.co.uk" <linux@...tec.co.uk>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "Ingo Molnar" <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        Len Brown <lenb@...nel.org>,
        "3chas3@...il.com" <3chas3@...il.com>,
        Harald Welte <laforge@...monks.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "Luck, Tony" <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        "mike.marciniszyn@...nelisnetworks.com" 
        <mike.marciniszyn@...nelisnetworks.com>,
        "dennis.dalessandro@...nelisnetworks.com" 
        <dennis.dalessandro@...nelisnetworks.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Pali Rohár <pali@...nel.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Karsten Keil <isdn@...ux-pingi.de>,
        "Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
        Frederic Barrat <fbarrat@...ux.ibm.com>,
        Andrew Donnellan <ajd@...ux.ibm.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Nicolas Pitre <nico@...xnic.net>,
        Loic Poulain <loic.poulain@...aro.org>,
        Kalle Valo <kvalo@...nel.org>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        "linux-arm Mailing List" <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Samsung SOC <linux-samsung-soc@...r.kernel.org>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>,
        "linux-atm-general@...ts.sourceforge.net" 
        <linux-atm-general@...ts.sourceforge.net>,
        netdev <netdev@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        "open list:HFI1 DRIVER" <linux-rdma@...r.kernel.org>,
        linux-input <linux-input@...r.kernel.org>,
        "open list:LINUX FOR POWERPC PA SEMI PWRFICIENT" 
        <linuxppc-dev@...ts.ozlabs.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "wcn36xx@...ts.infradead.org" <wcn36xx@...ts.infradead.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: RE: [PATCH 05/22] acpica: Replace comments with C99 initializers



-----Original Message-----
From: Andy Shevchenko <andy.shevchenko@...il.com> 
Sent: Sunday, March 27, 2022 1:00 PM
To: Benjamin Stürz <benni@...erz.xyz>
Cc: Andrew Lunn <andrew@...n.ch>; Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>; Gregory Clement <gregory.clement@...tlin.com>; Russell King - ARM Linux <linux@...linux.org.uk>; linux@...tec.co.uk; Krzysztof Kozlowski <krzk@...nel.org>; Alim Akhtar <alim.akhtar@...sung.com>; Thomas Gleixner <tglx@...utronix.de>; Ingo Molnar <mingo@...hat.com>; Borislav Petkov <bp@...en8.de>; Dave Hansen <dave.hansen@...ux.intel.com>; H. Peter Anvin <hpa@...or.com>; Moore, Robert <robert.moore@...el.com>; Wysocki, Rafael J <rafael.j.wysocki@...el.com>; Len Brown <lenb@...nel.org>; 3chas3@...il.com; Harald Welte <laforge@...monks.org>; Arnd Bergmann <arnd@...db.de>; Greg Kroah-Hartman <gregkh@...uxfoundation.org>; Mauro Carvalho Chehab <mchehab@...nel.org>; Luck, Tony <tony.luck@...el.com>; James Morse <james.morse@....com>; Robert Richter <rric@...nel.org>; Linus Walleij <linus.walleij@...aro.org>; Bartosz Golaszewski <brgl@...ev.pl>; mike.marciniszyn@...nelisnetworks.com; dennis.dalessandro@...nelisnetworks.com; Jason Gunthorpe <jgg@...pe.ca>; Pali Rohár <pali@...nel.org>; Dmitry Torokhov <dmitry.torokhov@...il.com>; Karsten Keil <isdn@...ux-pingi.de>; Benjamin Herrenschmidt <benh@...nel.crashing.org>; Frederic Barrat <fbarrat@...ux.ibm.com>; Andrew Donnellan <ajd@...ux.ibm.com>; David S. Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; Nicolas Pitre <nico@...xnic.net>; Loic Poulain <loic.poulain@...aro.org>; Kalle Valo <kvalo@...nel.org>; Ping-Ke Shih <pkshih@...ltek.com>; Bjorn Helgaas <bhelgaas@...gle.com>; linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; Linux Samsung SOC <linux-samsung-soc@...r.kernel.org>; linux-ia64@...r.kernel.org; ACPI Devel Maling List <linux-acpi@...r.kernel.org>; open list:ACPI COMPONENT ARCHITECTURE (ACPICA) <devel@...ica.org>; linux-atm-general@...ts.sourceforge.net; netdev <netdev@...r.kernel.org>; linux-edac@...r.kernel.org; open list:GPIO SUBSYSTEM <linux-gpio@...r.kernel.org>; open list:HFI1 DRIVER <linux-rdma@...r.kernel.org>; linux-input <linux-input@...r.kernel.org>; open list:LINUX FOR POWERPC PA SEMI PWRFICIENT <linuxppc-dev@...ts.ozlabs.org>; linux-media@...r.kernel.org; wcn36xx@...ts.infradead.org; linux-wireless@...r.kernel.org; linux-pci@...r.kernel.org
Subject: Re: [PATCH 05/22] acpica: Replace comments with C99 initializers

On Sat, Mar 26, 2022 at 7:39 PM Benjamin Stürz <benni@...erz.xyz> wrote:
>
> This replaces comments with C99's designated initializers because the 
> kernel supports them now.

Does it follow the conventions which are accepted in the ACPI CA project?

No, it doesn't. ACPICA must work with many compilers, some of which are rather old. So, we don't support these initializers.
Bob

--
With Best Regards,
Andy Shevchenko