linux-kernel - Re: RIP: 0010:param_get_bool.cold+0x0/0x2 - LTP read_all_sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 31 Mar 2022 21:27:42 +0200
From:   Jan Stancek <jstancek@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     Bruno Goncalves <bgoncalv@...hat.com>, kvm <kvm@...r.kernel.org>,
        "Bonzini, Paolo" <pbonzini@...hat.com>,
        lkml <linux-kernel@...r.kernel.org>,
        CKI Project <cki-project@...hat.com>,
        Li Wang <liwang@...hat.com>
Subject: Re: RIP: 0010:param_get_bool.cold+0x0/0x2 - LTP read_all_sys - 5.17.0

On Thu, Mar 31, 2022 at 8:46 PM Sean Christopherson <seanjc@...gle.com> wrote:
>
> On Thu, Mar 31, 2022, Sean Christopherson wrote:
> > On Wed, Mar 30, 2022, Jan Stancek wrote:
> > > +CC kvm
> > >
> > > Issue seems to be that nx_huge_pages is not initialized (-1) and
> > > attempted to be used as boolean when reading
> > > /sys/module/kvm/parameters/nx_huge_pages
> >
> > Ugh, CONFIG_UBSAN_BOOL=y complains about a bool not being 0 or 1.  What a pain.
>
> Side topic, any idea why your traces don't have the UBSAN output?  I verified

I guess that's because CONFIG_UBSAN_TRAP=y is also set.

# grep UBSAN -r .config
CONFIG_ARCH_HAS_UBSAN_SANITIZE_ALL=y
CONFIG_UBSAN=y
CONFIG_UBSAN_TRAP=y
CONFIG_CC_HAS_UBSAN_BOUNDS=y
CONFIG_UBSAN_BOUNDS=y
CONFIG_UBSAN_ONLY_BOUNDS=y
CONFIG_UBSAN_SHIFT=y
# CONFIG_UBSAN_DIV_ZERO is not set
CONFIG_UBSAN_BOOL=y
CONFIG_UBSAN_ENUM=y
CONFIG_UBSAN_SANITIZE_ALL=y
# CONFIG_TEST_UBSAN is not set

> that it's not a panic_on_warn thing.  Having the UBSAN output in future bug reports
> would be very helpful.
>
> [   13.150244] ================================================================================
> [   13.150780] UBSAN: invalid-load in kernel/params.c:320:33
> [   13.151192] load of value 255 is not a valid value for type '_Bool'
> [   13.152079] ================================================================================
>