linux-kernel - Re: [RFC] arm64: dts: ti: introduce a minimal am642 device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Mar 2022 12:28:08 +0530
From:   Vignesh Raghavendra <vigneshr@...com>
To:     Wadim Egorov <w.egorov@...tec.de>, Bryan Brattlof <bb@...com>,
        Nishanth Menon <nm@...com>, Tero Kristo <kristo@...nel.org>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] arm64: dts: ti: introduce a minimal am642 device tree

Hi Wadim,

On 30/03/22 7:25 pm, Wadim Egorov wrote:
> Hi Bryan,
> 
>> +/* (optional) for console */
>> +&main_uart0 {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&main_uart0_pins_default>;
>> +};
>> +
>> +/* reserved for firmware */
>> +&main_uart1 {
>> +    status = "reserved";
>> +};
> 
> k3-image-gen says UART0 is used as a debug interface. See
> 
> 
> https://git.ti.com/cgit/k3-image-gen/k3-image-gen/tree/soc/am64x/evm/board-cfg.c#n81
> 
> 
> So it seems that you can enable uart1 here. But people may run into a
> conflict with uart0 and k3-image-gen compiled with ENABLE_TRACE=1.
> 
> If I am wrong, can you please clarify why you mark uart1 as reserved.
> 

We just seem to have same macro shared across multiple SoCs,
BOARDCFG_TRACE_DST_UART0 means logs are also directed to UART. Instance
of UART used for logging is platform specific.

On AM64 SYSFW logs are directed to MAIN UART1 (MAIN UART0 is used for
linux console). I will work internally and get SYSFW documentation
updated to reflect the same. Thanks!

Regards
Vignesh