linux-kernel - Re: [PATCH v3] misc/mei: Add NULL check to component match callback functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkVz+1HkSeXcIux2@kuha.fi.intel.com>
Date:   Thu, 31 Mar 2022 12:27:23 +0300
From:   Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:     Won Chung <wonchung@...gle.com>
Cc:     Tomas Winkler <tomas.winkler@...el.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Benson Leung <bleung@...omium.org>,
        Prashant Malani <pmalani@...omium.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v3] misc/mei: Add NULL check to component match callback
 functions

Hi Won,

On Thu, Mar 31, 2022 at 08:49:18AM +0000, Won Chung wrote:
> Component match callback functions need to check if expected data is
> passed to them. Without this check, it can cause a NULL pointer
> dereference when another driver registers a component before i915
> drivers have their component master fully bind.
> 
> Fixes: 1e8d19d9b0dfc ("mei: hdcp: bind only with i915 on the same PCH")
> Fixes: c2004ce99ed73 ("mei: pxp: export pavp client to me client bus")
> Suggested-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Suggested-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Signed-off-by: Won Chung <wonchung@...gle.com>
> Cc: stable@...r.kernel.org
> ---
> Changes from v2:
> - Correctly add "Suggested-by" tag
> - Add "Cc: stable@...r.kernel.org"
> 
> Changes from v1:
> - Add "Fixes" tag
> - Send to stable@...r.kernel.org

You are sending these really fast. Before you send the next one,
please wait for at least one day.

thanks,

-- 
heikki