linux-kernel - Re: [PATCH] staging: gdm724x: Fix Duplication of Side Effects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Mar 2022 13:40:12 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     David Laight <David.Laight@...LAB.COM>
Cc:     'Alaa Mohamed' <eng.alaamohamedsoliman.am@...il.com>,
        "outreachy@...ts.linux.dev" <outreachy@...ts.linux.dev>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: gdm724x: Fix Duplication of Side Effects

On Thu, Mar 31, 2022 at 10:29:04AM +0000, David Laight wrote:
> From: Alaa Mohamed
> > Sent: 31 March 2022 11:19
> > 
> > Fix Duplication of Side Effects for GDM_TTY_READY(gdm) macro
> > reported by checkpatch
> > "CHECK: Macro argument reuse 'gdm' - possible side-effects?"
> > 
> > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@...il.com>
> > ---
> >  drivers/staging/gdm724x/gdm_tty.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c
> > index 04df6f9f5403..6f0274470e69 100644
> > --- a/drivers/staging/gdm724x/gdm_tty.c
> > +++ b/drivers/staging/gdm724x/gdm_tty.c
> > @@ -27,7 +27,9 @@
> > 
> >  #define MUX_TX_MAX_SIZE 2048
> > 
> > -#define GDM_TTY_READY(gdm) (gdm && gdm->tty_dev && gdm->port.count)
> > +#define GDM_TTY_READY(_gdm) \
> > +	({ typeof(_gdm) (gdm) = (_gdm); \
> > +	(gdm && gdm->tty_dev && gdm->port.count); })
> 
> Did you test this?
> 
> see https://godbolt.org/z/cazPrrzPv
> 

I don't understand the link.  The patch should work as far as I can see.

regards,
dan carpenter