linux-kernel - Re: [RFC 1/1] kernel/sysctl: Add sysctl entry for crash_kexec_post

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkdwB4Yh0hNgEyOa@bombadil.infradead.org>
Date:   Fri, 1 Apr 2022 14:35:03 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Alejandro Jimenez <alejandro.j.jimenez@...cle.com>
Cc:     corbet@....net, keescook@...omium.org, yzaikin@...gle.com,
        linux-fsdevel@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        linux@...musvillemoes.dk, ebiggers@...gle.com,
        peterz@...radead.org, ying.huang@...el.com, gpiccoli@...lia.com,
        mchehab+huawei@...nel.org, Jason@...c4.com, daniel@...earbox.net,
        robh@...nel.org, wangqing@...o.com, prestwoj@...il.com,
        dsahern@...nel.org, stephen.s.brennan@...cle.com
Subject: Re: [RFC 1/1] kernel/sysctl: Add sysctl entry for
 crash_kexec_post_notifiers

On Fri, Apr 01, 2022 at 04:23:00PM -0400, Alejandro Jimenez wrote:
> diff --git a/kernel/sysctl.c b/kernel/sysctl.c
> index 830aaf8ca08e..8e0be72b5fba 100644
> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -2339,6 +2339,13 @@ static struct ctl_table kern_table[] = {
>  		.extra2		= SYSCTL_INT_MAX,
>  	},
>  #endif
> +	{
> +		.procname	= "crash_kexec_post_notifiers",
> +		.data		= &crash_kexec_post_notifiers,
> +		.maxlen		= sizeof(int),
> +		.mode		= 0644,
> +		.proc_handler	= proc_dobool,
> +	},
>  	{ }

Please don't add any new sysctls to this file anymore. See
sysctl-testing which trims its uses. Plenty of examples for you
to see what to do, hopefully [0].

[0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/log/?h=sysctl-testing

  Luis