linux-kernel - Re: [PATCH v2] staging: unisys: Remove "struct dentry *eth_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YkaVPtpgLk7zc1e/@kroah.com>
Date:   Fri, 1 Apr 2022 08:01:34 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Fabio M. De Francesco" <fmdefrancesco@...il.com>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        sparmaintainer@...sys.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org, outreachy@...ts.linux.dev
Subject: Re: [PATCH v2] staging: unisys: Remove "struct dentry
 *eth_debugfs_dir"

On Thu, Mar 31, 2022 at 06:58:58PM +0200, Fabio M. De Francesco wrote:
> On gioved? 31 marzo 2022 10:22:02 CEST Dan Carpenter wrote:
> > On Thu, Mar 31, 2022 at 08:47:51AM +0200, Fabio M. De Francesco wrote:
> > > There is no need for "struct dentry *eth_debugfs_dir" which is used for
> > > debug / sysfs directories. Therefore, remove this "struct dentry" and
> > > everything related (i.e., creation and removal).
> > > 
> > > As a side effect of this change, the code has no more need of the
> > > "cleanup_register_netdev" label, which can also be removed.
> > > 
> > > Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> > > Suggested-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@...il.com>
> > > ---
> > > 
> > > v1 - v2: Add a couple of "Suggested-by" tags which were forgotten. 
> > > Thanks to Dan Carpenter and Greg Kroah-Hartman.
> > > 
> > 
> > Thanks!
> > 
> > Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>
> > 
> > regards,
> > dan carpenter
> > 
> I've just noticed that visornic and visorhba do other calls to 
> debugfs_create_dir() and debugfs_create_file() functions.
> 
> I'm not sure whether or not this driver still needs those other calls.

It looks like those drivers create actual files in debugfs with
information in them, so I would leave them alone.

thanks,

greg k-h