linux-kernel - Re: [PATCH][next] iwlwifi: fw: Replace zero-length arrays with flexible-array members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Apr 2022 08:10:06 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "gustavo@...eddedor.com" <gustavo@...eddedor.com>,
        "gustavoars@...nel.org" <gustavoars@...nel.org>
CC:     "keescook@...omium.org" <keescook@...omium.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-hardening@...r.kernel.org" <linux-hardening@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH][next] iwlwifi: fw: Replace zero-length arrays with
 flexible-array members

On Mon, 2022-03-28 at 01:23 -0500, Gustavo A. R. Silva wrote:
> 
> On 3/28/22 00:47, Kalle Valo wrote:
> > "Gustavo A. R. Silva" <gustavoars@...nel.org> writes:
> > 
> > > On Wed, Feb 16, 2022 at 12:35:14PM -0800, Kees Cook wrote:
> > > > On Wed, Feb 16, 2022 at 01:50:15PM -0600, Gustavo A. R. Silva wrote:
> > > > > There is a regular need in the kernel to provide a way to declare
> > > > > having a dynamically sized set of trailing elements in a structure.
> > > > > Kernel code should always use “flexible array members”[1] for these
> > > > > cases. The older style of one-element or zero-length arrays should
> > > > > no longer be used[2].
> > > > > 
> > > > > [1] https://en.wikipedia.org/wiki/Flexible_array_member
> > > > > [2]
> > > > > https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
> > > > > 
> > > > > Link: https://github.com/KSPP/linux/issues/78
> > > > > Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> > > > 
> > > > Reviewed-by: Kees Cook <keescook@...omium.org>
> > > 
> > > Hi all,
> > > 
> > > Friendly ping: can someone take this, please?
> > > 
> > > ...I can take this in my -next tree in the meantime.
> > 
> > Like we have discussed before, please don't take any wireless patches to
> > your tree. The conflicts just cause more work of us.
> 
> Sure thing. I just removed it from my tree.
> 
> I didn't get any reply from wireless people in more than a month, and
> that's why I temporarily took it in my tree so it doesn't get lost. :)
> 
> > I assigned this patch to me on patchwork and I'm planning to take it to
> > wireless-next once it opens. Luca, ack?

Sorry for the delay, I was on vacation.

As you some of you already know, I'm stepping aside from my role as
iwlwifi maintainer (FWIW I'm moving to Intel Graphics).  I can still
ack this change, but we'll soon send an update to MAINTAINERS to
reflect the change.

Acked-by: Luca Coelho <luciano.coelho@...el.com>

--
Cheers,
Luca.