linux-kernel - Re: [PATCH][next] iwlwifi: fw: Replace zero-length arrays with flexible-array members

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871qyhuizl.fsf@kernel.org>
Date:   Fri, 01 Apr 2022 14:43:26 +0300
From:   Kalle Valo <kvalo@...nel.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Luca Coelho <luciano.coelho@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH][next] iwlwifi: fw: Replace zero-length arrays with flexible-array members

"Gustavo A. R. Silva" <gustavo@...eddedor.com> writes:

> On 3/28/22 00:47, Kalle Valo wrote:
>> "Gustavo A. R. Silva" <gustavoars@...nel.org> writes:
>>
>>> On Wed, Feb 16, 2022 at 12:35:14PM -0800, Kees Cook wrote:
>>>> On Wed, Feb 16, 2022 at 01:50:15PM -0600, Gustavo A. R. Silva wrote:
>>>>> There is a regular need in the kernel to provide a way to declare
>>>>> having a dynamically sized set of trailing elements in a structure.
>>>>> Kernel code should always use “flexible array members”[1] for these
>>>>> cases. The older style of one-element or zero-length arrays should
>>>>> no longer be used[2].
>>>>>
>>>>> [1] https://en.wikipedia.org/wiki/Flexible_array_member
>>>>> [2]
>>>>> https://www.kernel.org/doc/html/v5.16/process/deprecated.html#zero-length-and-one-element-arrays
>>>>>
>>>>> Link: https://github.com/KSPP/linux/issues/78
>>>>> Signed-off-by: Gustavo A. R. Silva <gustavoars@...nel.org>
>>>>
>>>> Reviewed-by: Kees Cook <keescook@...omium.org>
>>>
>>> Hi all,
>>>
>>> Friendly ping: can someone take this, please?
>>>
>>> ...I can take this in my -next tree in the meantime.
>>
>> Like we have discussed before, please don't take any wireless patches to
>> your tree. The conflicts just cause more work of us.
>
> Sure thing. I just removed it from my tree.
>
> I didn't get any reply from wireless people in more than a month, and
> that's why I temporarily took it in my tree so it doesn't get lost. :)

That increases the risk of conflicts and, because of multiple trees we
have, the conflicts cause more work for us. Please don't take ANY
wireless patches to your tree (or any other tree for that matter) unless
Johannes or me has acked them.

If you don't get reply to your patch for few weeks (and the merge window
is not open), you can ping in the list or contact me.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches