linux-kernel - Re: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkcBt74odxdoBlQ3@smile.fi.intel.com>
Date:   Fri, 1 Apr 2022 16:44:23 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Sandipan Patra <spatra@...dia.com>
Cc:     treding@...dia.com, jonathanh@...dia.com, digetx@...il.com,
        ulf.hansson@...aro.org, cai.huoqing@...ux.dev, bbasu@...dia.com,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources

On Fri, Apr 01, 2022 at 04:19:35PM +0530, Sandipan Patra wrote:
> Reset_sources list is updated to add all reset sources
> and removing ones that do not actually exist.

...

> +	NULL,		/* 0x10 */

I would suggest to add the comments more often, like every 8 entries.

...

> +	"FSI_VMON"	/* 0x25 */

It would be good to have comma here as if this ever getting expanded
the additional churn may be avoided.

>  };

-- 
With Best Regards,
Andy Shevchenko