linux-kernel - RE: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 1 Apr 2022 14:33:12 +0000
From:   Sandipan Patra <spatra@...dia.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
CC:     Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "digetx@...il.com" <digetx@...il.com>,
        "ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
        "cai.huoqing@...ux.dev" <cai.huoqing@...ux.dev>,
        Bibek Basu <bbasu@...dia.com>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources

Thank you Andy.
Pushed V3 patch addressing recent comments.
Please help to review.


Thanks & Regards,
Sandipan

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Friday, April 1, 2022 7:14 PM
> To: Sandipan Patra <spatra@...dia.com>
> Cc: Thierry Reding <treding@...dia.com>; Jonathan Hunter
> <jonathanh@...dia.com>; digetx@...il.com; ulf.hansson@...aro.org;
> cai.huoqing@...ux.dev; Bibek Basu <bbasu@...dia.com>; linux-
> tegra@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [Patch V2] soc/tegra: pmc: update Tegra234 reset sources
> 
> External email: Use caution opening links or attachments
> 
> 
> On Fri, Apr 01, 2022 at 04:19:35PM +0530, Sandipan Patra wrote:
> > Reset_sources list is updated to add all reset sources and removing
> > ones that do not actually exist.
> 
> ...
> 
> > +     NULL,           /* 0x10 */
> 
> I would suggest to add the comments more often, like every 8 entries.
> 
> ...
> 
> > +     "FSI_VMON"      /* 0x25 */
> 
> It would be good to have comma here as if this ever getting expanded the
> additional churn may be avoided.
> 
> >  };
> 
> --
> With Best Regards,
> Andy Shevchenko
>