linux-kernel - drivers/cxl/pci.c:439:7: warning: Local variable 'rc' shadows outer variable [shadowVariable]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <202204021950.bTbpM2Gy-lkp@intel.com>
Date:   Sat, 2 Apr 2022 19:26:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ben Widawsky <ben.widawsky@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Dan Williams <dan.j.williams@...el.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: drivers/cxl/pci.c:439:7: warning: Local variable 'rc' shadows outer
 variable [shadowVariable]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   88e6c0207623874922712e162e25d9dafd39661e
commit: 523e594d9cc03db962c741ce02c8a58aab58a123 cxl/pci: Implement wait for media active
date:   7 weeks ago
compiler: alpha-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


cppcheck warnings: (new ones prefixed by >>)
>> drivers/cxl/pci.c:439:7: warning: Local variable 'rc' shadows outer variable [shadowVariable]
     int rc;
         ^
   drivers/cxl/pci.c:431:6: note: Shadowed declaration
    int rc, i;
        ^
   drivers/cxl/pci.c:439:7: note: Shadow variable
     int rc;
         ^

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> drivers/cxl/port.c:63:1: warning: There is an unknown macro here somewhere. Configuration is required. If __stringify is a macro then please configure it. [unknownMacro]
   MODULE_ALIAS_CXL(CXL_DEVICE_PORT);
   ^
--

vim +/rc +439 drivers/cxl/pci.c

   420	
   421	/*
   422	 * Wait up to @mbox_ready_timeout for the device to report memory
   423	 * active.
   424	 */
   425	static int wait_for_media_ready(struct cxl_dev_state *cxlds)
   426	{
   427		struct pci_dev *pdev = to_pci_dev(cxlds->dev);
   428		int d = cxlds->cxl_dvsec;
   429		bool active = false;
   430		u64 md_status;
   431		int rc, i;
   432	
   433		rc = wait_for_valid(cxlds);
   434		if (rc)
   435			return rc;
   436	
   437		for (i = mbox_ready_timeout; i; i--) {
   438			u32 temp;
 > 439			int rc;
   440	
   441			rc = pci_read_config_dword(
   442				pdev, d + CXL_DVSEC_RANGE_SIZE_LOW(0), &temp);
   443			if (rc)
   444				return rc;
   445	
   446			active = FIELD_GET(CXL_DVSEC_MEM_ACTIVE, temp);
   447			if (active)
   448				break;
   449			msleep(1000);
   450		}
   451	
   452		if (!active) {
   453			dev_err(&pdev->dev,
   454				"timeout awaiting memory active after %d seconds\n",
   455				mbox_ready_timeout);
   456			return -ETIMEDOUT;
   457		}
   458	
   459		md_status = readq(cxlds->regs.memdev + CXLMDEV_STATUS_OFFSET);
   460		if (!CXLMDEV_READY(md_status))
   461			return -EIO;
   462	
   463		return 0;
   464	}
   465	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp