linux-kernel - Re: drivers/cxl/pci.c:439:7: warning: Local variable 'rc' shadows outer variable [shadowVariable]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e4d381f0-bafc-771b-7298-cfc6685776f0@infradead.org>
Date:   Sun, 3 Apr 2022 12:29:00 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     kernel test robot <lkp@...el.com>,
        Ben Widawsky <ben.widawsky@...el.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Dan Williams <dan.j.williams@...el.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>
Subject: Re: drivers/cxl/pci.c:439:7: warning: Local variable 'rc' shadows
 outer variable [shadowVariable]

Hi lkp/ktr,

On 4/2/22 04:26, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   88e6c0207623874922712e162e25d9dafd39661e
> commit: 523e594d9cc03db962c741ce02c8a58aab58a123 cxl/pci: Implement wait for media active
> date:   7 weeks ago
> compiler: alpha-linux-gcc (GCC) 11.2.0
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> 
> cppcheck warnings: (new ones prefixed by >>)
>>> drivers/cxl/pci.c:439:7: warning: Local variable 'rc' shadows outer variable [shadowVariable]
>      int rc;
>          ^
>    drivers/cxl/pci.c:431:6: note: Shadowed declaration
>     int rc, i;
>         ^
>    drivers/cxl/pci.c:439:7: note: Shadow variable
>      int rc;
>          ^
> 
> cppcheck possible warnings: (new ones prefixed by >>, may not real problems)
> 
>>> drivers/cxl/port.c:63:1: warning: There is an unknown macro here somewhere. Configuration is required. If __stringify is a macro then please configure it. [unknownMacro]
>    MODULE_ALIAS_CXL(CXL_DEVICE_PORT);
>    ^
> --

Can you provide a cppcheck config file and command line
for this, please?

My naive testing does not see any of these warnings --
although I can easily spot the problems in the source file.

thanks.
-- 
~Randy