linux-kernel - Re: [PATCH] staging: r8188eu: Remove goto to no-op exit label

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2108195.Mh6RI2rZIc@leap>
Date:   Sat, 02 Apr 2022 15:22:23 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     Ira Weiny <ira.weiny@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: r8188eu: Remove goto to no-op exit label

On sabato 2 aprile 2022 13:45:33 CEST Martin Kaiser wrote:
> Thus wrote Fabio M. De Francesco (fmdefrancesco@...il.com):
> 
> > > >  	pnpi = netdev_priv(netdev);
> 
> > > >  	if (!pnpi->priv)
> > > > -		goto RETURN;
> > > > +		return;
> 
> > I cannot see how pnpi->priv might ever be NULL.
> 
> Even if pnpi->priv was NULL, we wouldn't need the check. It's ok to call
> vfree(NULL).
> 
> > After the two removals I've talked about above, the code will always call 
> > vfree(pnpi->priv) and then free_netdev(netdev).
> 
> That makes sense.
> 
> Best regards,
> Martin
> 
Hi Martin,

Thanks for reminding to me that a vfree() on a NULL pointer is a no-op.
I'm going to submit a new patch with the purpose to re-work rtw_free_netdev().

Thanks again,

Fabio