[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 4 Apr 2022 12:59:57 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Ira Weiny <ira.weiny@...el.com>
Cc: "Fabio M. De Francesco" <fmdefrancesco@...il.com>,
Larry Finger <Larry.Finger@...inger.net>,
Phillip Potter <phil@...lpotter.co.uk>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
outreachy@...ts.linux.dev
Subject: Re: [PATCH] staging: r8188eu: Remove goto to no-op exit label
On Fri, Apr 01, 2022 at 01:41:40PM -0700, Ira Weiny wrote:
> On Fri, Apr 01, 2022 at 08:35:13PM +0200, Fabio M. De Francesco wrote:
> > In function rtw_free_netdev() there are two "goto" jumps to a no-op exit
> > label called "RETURN". Remove the label and return in line.
>
> Thanks for the patch! However, A good commit message lists the why and what of
> a change. I don't see a why for this commit?
People, stop belly aching about commit messages.
"Delete no-op goto" is sufficient justification.
regards,
dan carpenter
Powered by blists - more mailing lists