linux-kernel - Re: [PATCH 6/6] staging: r8188eu: remove spaces before tabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <583569c9-baf0-b478-d14a-4a2beb3708d3@lwfinger.net>
Date:   Sat, 2 Apr 2022 11:42:26 -0500
From:   Larry Finger <Larry.Finger@...inger.net>
To:     Rebecca Mckeever <remckee0@...il.com>, outreachy@...ts.linux.dev
Cc:     Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/6] staging: r8188eu: remove spaces before tabs

On 4/2/22 03:50, Rebecca Mckeever wrote:
> Conform to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> WARNING: please, no space before tabs
> 
> Signed-off-by: Rebecca Mckeever <remckee0@...il.com>
> ---
>   drivers/staging/r8188eu/core/rtw_cmd.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_cmd.c b/drivers/staging/r8188eu/core/rtw_cmd.c
> index 832bf25b1a83..8ae25cb4246b 100644
> --- a/drivers/staging/r8188eu/core/rtw_cmd.c
> +++ b/drivers/staging/r8188eu/core/rtw_cmd.c
> @@ -548,9 +548,9 @@ u8 rtw_joinbss_cmd(struct adapter  *padapter, struct wlan_network *pnetwork)
>   
>   	phtpriv->ht_option = false;
>   	if (pregistrypriv->ht_enable) {
> -		/* 	Added by Albert 2010/06/23 */
> -		/* 	For the WEP mode, we will use the bg mode to do the connection to avoid some IOT issue. */
> -		/* 	Especially for Realtek 8192u SoftAP. */
> +		/*	Added by Albert 2010/06/23 */
> +		/*	For the WEP mode, we will use the bg mode to do the connection to avoid some IOT issue. */
> +		/*	Especially for Realtek 8192u SoftAP. */
>   		if ((padapter->securitypriv.dot11PrivacyAlgrthm != _WEP40_) &&
>   		    (padapter->securitypriv.dot11PrivacyAlgrthm != _WEP104_) &&
>   		    (padapter->securitypriv.dot11PrivacyAlgrthm != _TKIP_)) {
> @@ -1010,7 +1010,7 @@ u8 rtw_lps_ctrl_wk_cmd(struct adapter *padapter, u8 lps_ctrl_type, u8 enqueue)
>   	u8	res = _SUCCESS;
>   
>   	/* if (!pwrctrlpriv->bLeisurePs) */
> -	/* 	return res; */
> +	/*	return res; */
>   
>   	if (enqueue) {
>   		ph2c = kzalloc(sizeof(struct cmd_obj), GFP_ATOMIC);
> @@ -1151,8 +1151,8 @@ u8 p2p_protocol_wk_cmd(struct adapter *padapter, int intCmdType)
>   	}
>   
>   	pdrvextra_cmd_parm->ec_id = P2P_PROTO_WK_CID;
> -	pdrvextra_cmd_parm->type_size = intCmdType;	/* 	As the command tppe. */
> -	pdrvextra_cmd_parm->pbuf = NULL;		/* 	Must be NULL here */
> +	pdrvextra_cmd_parm->type_size = intCmdType;	/*	As the command tppe. */
> +	pdrvextra_cmd_parm->pbuf = NULL;		/*	Must be NULL here */
>   
>   	init_h2fwcmd_w_parm_no_rsp(ph2c, pdrvextra_cmd_parm, GEN_CMD_CODE(_Set_Drv_Extra));
>   
> @@ -1378,8 +1378,8 @@ u8 rtw_drvextra_cmd_hdl(struct adapter *padapter, unsigned char *pbuf)
>   		p2p_ps_wk_hdl(padapter, pdrvextra_cmd->type_size);
>   		break;
>   	case P2P_PROTO_WK_CID:
> -		/* 	Commented by Albert 2011/07/01 */
> -		/* 	I used the type_size as the type command */
> +		/*	Commented by Albert 2011/07/01 */
> +		/*	I used the type_size as the type command */
>   		p2p_protocol_wk_hdl(padapter, pdrvextra_cmd->type_size);
>   		break;
>   	case CHECK_HIQ_WK_CID:

Congratulations on a very clear set of patches. Each performs a single change 
exactly as required by the rules.

For all 6,
Acked-by: Larry Finger <Larry.Finger@...inger.net>

Thanks,
Larry