linux-kernel - Re: [PATCH] Revert "clk: Drop the rate range on clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 04 Apr 2022 13:05:28 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Maxime Ripard <maxime@...no.tech>
Cc:     Michael Turquette <mturquette@...libre.com>,
        linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Tony Lindgren <tony@...mide.com>,
        Alexander Stein <alexander.stein@...tq-group.com>,
        Naresh Kamboju <naresh.kamboju@...aro.org>
Subject: Re: [PATCH] Revert "clk: Drop the rate range on clk_put()"

Quoting Maxime Ripard (2022-04-04 00:29:00)
> On Sat, Apr 02, 2022 at 07:28:18PM -0700, Stephen Boyd wrote:
> > This reverts commit 7dabfa2bc4803eed83d6f22bd6f045495f40636b. There are
> > multiple reports that this breaks boot on various systems. The common
> > theme is that orphan clks are having rates set on them when that isn't
> > expected. Let's revert it out for now so that -rc1 boots.
> > 
> > Reported-by: Marek Szyprowski <m.szyprowski@...sung.com>
> > Reported-by: Tony Lindgren <tony@...mide.com>
> > Reported-by: Alexander Stein <alexander.stein@...tq-group.com>
> > Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> > Link: https://lore.kernel.org/r/366a0232-bb4a-c357-6aa8-636e398e05eb@samsung.com
> > Cc: Maxime Ripard <maxime@...no.tech>
> > Signed-off-by: Stephen Boyd <sboyd@...nel.org>
> 
> I really like the attention it's getting now that it's broken, we can
> fix a lot of things :)

Sure! Except that can quickly turn into other attention.

> 
> It doesn't seem to be restricted to orphan clocks though :/

Oof ok. I was busy last week so couldn't pay much attention.

> 
> But obviously,
> Acked-by: Maxime Ripard <maxime@...no.tech>

Thanks. Looks like it just made -rc1 so we can work through the fix at a
more leisurely pace now.