linux-kernel - Re: [PATCH v8 00/23] userfaultfd-wp: Support shmem and hugetlbfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkzKiM8tI4+qOfXF@xz-m1.local>
Date:   Tue, 5 Apr 2022 19:02:32 -0400
From:   Peter Xu <peterx@...hat.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        Mike Kravetz <mike.kravetz@...cle.com>,
        David Hildenbrand <david@...hat.com>,
        Matthew Wilcox <willy@...radead.org>,
        Alistair Popple <apopple@...dia.com>,
        Nadav Amit <nadav.amit@...il.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        Hugh Dickins <hughd@...gle.com>,
        Jerome Glisse <jglisse@...hat.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>
Subject: Re: [PATCH v8 00/23] userfaultfd-wp: Support shmem and hugetlbfs

On Tue, Apr 05, 2022 at 03:49:12PM -0700, Andrew Morton wrote:
> On Tue, 5 Apr 2022 18:42:43 -0400 Peter Xu <peterx@...hat.com> wrote:
> 
> > On Tue, Apr 05, 2022 at 03:16:16PM -0700, Andrew Morton wrote:
> > > On Mon,  4 Apr 2022 21:46:23 -0400 Peter Xu <peterx@...hat.com> wrote:
> > > 
> > > > This is v8 of the series to add shmem+hugetlbfs support for userfaultfd
> > > > write protection. 
> > > 
> > > Various compilation catastrophes with x86_64 allnoconfig.  I poked at
> > > the include ordering for a while but other things quickly became more
> > > attractive ;)
> > 
> > Sorry about that.  I still don't know what's the problem, but I'll give it
> > a shot soon.
> > 
> > I think I only tried out with the new configs but not all the rest configs.
> > I thought there're some bot looking after that one, from which I used to
> > receive build reports. And IIRC I fixed some build issues in early versions
> > from those reports.  Maybe I was wrong..
> > 
> > Any more hints on the latter?
> 
> `make allnoconfig'?
> 

Ah!  I thought when you mentioned "other things" you meant there're other
more severe issues... :)

For the allnoconfig, could you try with the attached quick fixup (upon
patch "mm/uffd: PTE_MARKER_UFFD_WP")?

That works for me on x86/arm, but I'm still trying out some other configs.

Thanks,

-- 
Peter Xu

View attachment "0001-fixup-mm-uffd-PTE_MARKER_UFFD_WP.patch" of type "text/plain" (893 bytes)