linux-kernel - Re: [PATCH V9 4/6] regulator: Add a regulator driver for the PM8008 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <85ceeb51-56d2-4e87-c67d-c203a30ecfec@quicinc.com>
Date:   Wed, 6 Apr 2022 14:36:04 +0530
From:   "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@...cinc.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <swboyd@...omium.org>,
        <quic_collinsd@...cinc.com>, <quic_subbaram@...cinc.com>,
        <quic_jprakash@...cinc.com>
Subject: Re: [PATCH V9 4/6] regulator: Add a regulator driver for the PM8008
 PMIC


On 4/5/2022 7:47 PM, Mark Brown wrote:
> On Tue, Apr 05, 2022 at 07:20:31PM +0530, Satya Priya wrote:
>
>> +#include <linux/regulator/driver.h>
>> +#include <linux/regulator/machine.h>
> Why does the driver need machine.h?  That's usually a bug, though I
> didn't spot anywhere where it's used so it's probably just an extra
> header.


Yeah, I'll remove it. Thanks for spotting this.


>> +	.set_voltage_sel	= pm8008_regulator_set_voltage,
>> +	.get_voltage		= pm8008_regulator_get_voltage,
> You shouldn't mix and match the selector and non-selector operations,
> since the device just takes a voltage you may as well just use the
> non-selector version for both.


I was suggested to use set_voltage_sel on my previous posts. I think 
I'll use get_voltage_sel to avoid mixing selector and non-selector APIs.


> Otherwise this all looks good, just those two minor points.