linux-kernel - Re: [PATCH] Bluetooth: hci_qca: Use del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <59941012-6eb6-91f3-ac79-cca759fa53d7@roeck-us.net>
Date:   Wed, 6 Apr 2022 09:36:10 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Eric Dumazet <eric.dumazet@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        Ben Young Tae Kim <ytkim@....qualcomm.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] Bluetooth: hci_qca: Use del_timer_sync() before freeing

On 4/6/22 08:46, Steven Rostedt wrote:
> On Wed, 6 Apr 2022 08:39:07 -0700
> Guenter Roeck <linux@...ck-us.net> wrote:
> 
>>> ie move this destroy_workqueue() up ?
>>>    
>>
>> What prevents the timer code from queueing work into the destroyed
>> workqueue ?
> 
> So we have a chicken verses egg issue here?
> 

Almost looks like it, unless I am missing something. Maybe some flag
is needed to prevent the timer handling code from queuing into the
destroyed workqueue, or the workqueue handler from updating the timer.

Guenter