linux-kernel - Re: [PATCH V9 4/6] regulator: Add a regulator driver for the PM8008 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk3Bfnxe/meBYokp@sirena.org.uk>
Date:   Wed, 6 Apr 2022 17:36:14 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Satya Priya <quic_c_skakit@...cinc.com>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, quic_collinsd@...cinc.com,
        quic_subbaram@...cinc.com, quic_jprakash@...cinc.com
Subject: Re: [PATCH V9 4/6] regulator: Add a regulator driver for the PM8008
 PMIC

On Wed, Apr 06, 2022 at 08:51:48AM -0700, Stephen Boyd wrote:
> Quoting Mark Brown (2022-04-06 08:45:41)

> > There's a MFD parent for it, and if it's for an I2C device for a pm8008
> > why would it have a -regulators in the name?

> There are two i2c devices. One is pm8008 at i2c address 0x8 and one is
> pm8008-regulators at i2c address 0x9. Earlier revisions of this patch
> series were making it very confusing by redoing the pm8008 binding and
> adding the pm8008-regulator i2c address device to the same binding and
> driver.

> My guess is that this is one IC that responds to multiple i2c addresses.
> The "main" qcom,pm8008 address is 0x8 and that supports things like
> interrupts. Then there's an address for regulators at 0x9 which controls
> the handful of LDOs on the PMIC.

So it's like the TI TWL4030 and Palmas - in which case it should
probably be handled similarly?  Note that the original sumbission was
*also* a MFD subfunction, but using a DT compatible to match the
platform device - this is the first I've heard of this being a separate
I2C function.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)