linux-kernel - Re: [PATCH 1/2] dt-bindings: spi: cadence-quadspi: Add reset-gpios for Xilinx Versal OSPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk3an4F0s2p0vxKi@robh.at.kernel.org>
Date:   Wed, 6 Apr 2022 13:23:27 -0500
From:   Rob Herring <robh@...nel.org>
To:     Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>
Cc:     Mark Brown <broonie@...nel.org>, Pratyush Yadav <p.yadav@...com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-spi@...r.kernel.org, Michal Simek <michal.simek@...inx.com>,
        git@...inx.com, saikrishna12468@...il.com, sgoud@...inx.com
Subject: Re: [PATCH 1/2] dt-bindings: spi: cadence-quadspi: Add reset-gpios
 for Xilinx Versal OSPI

On Tue, Apr 05, 2022 at 04:30:36PM +0530, Sai Krishna Potthuri wrote:
> Add reset-gpios property to the properties list and marked as required
> for Xilinx Versal OSPI compatible. This is used to perform the HW reset
> for OSPI flash device.
> 
> Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@...inx.com>
> ---
>  Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> index 0a537fa3a641..56001eaf6365 100644
> --- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> +++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
> @@ -19,6 +19,7 @@ allOf:
>      then:
>        required:
>          - power-domains
> +        - reset-gpios
>  
>  properties:
>    compatible:
> @@ -78,6 +79,12 @@ properties:
>    power-domains:
>      maxItems: 1
>  
> +  reset-gpios:
> +    description:
> +      Contains a phandle and GPIO specifier for reset with the default active
> +      state.

Other than 'for reset' that's every GPIO property. Just drop unless you 
have something specific to cdns,qspi-nor to say.

However, a reset for the flash device belongs in the flash device node, 
not the controller node.

Rob