linux-kernel - Re: [PATCH v5 8/8] dt-bindings: net: dwmac-imx: Document clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk3WHSr+OGRxYCg0@robh.at.kernel.org>
Date:   Wed, 6 Apr 2022 13:04:13 -0500
From:   Rob Herring <robh@...nel.org>
To:     Abel Vesa <abel.vesa@....com>
Cc:     Dong Aisheng <aisheng.dong@....com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        devicetree@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v5 8/8] dt-bindings: net: dwmac-imx: Document clk_csr
 property

On Mon, Apr 04, 2022 at 04:46:09PM +0300, Abel Vesa wrote:
> The clk_csr property is used for CSR clock range selection.

Why?

> 
> Signed-off-by: Abel Vesa <abel.vesa@....com>
> ---
>  Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> index 011363166789..1556d95943f6 100644
> --- a/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> +++ b/Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
> @@ -32,6 +32,10 @@ properties:
>                - nxp,imx8dxl-dwmac-eqos
>            - const: snps,dwmac-5.10a
>  
> +  clk_csr:

s/_/-/

vendor prefix needed. 

And a type is needed.

> +    description: |
> +      Fixed CSR Clock Range selection

What? Explain all this to someone that doesn't know your h/w.

> +
>    clocks:
>      minItems: 3
>      items:
> -- 
> 2.34.1
> 
>