linux-kernel - Re: [RFC PATCH 0/8] media: hantro: Add 10-bit support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2820101.e9J7NaK4W3@jernej-laptop>
Date:   Wed, 06 Apr 2022 19:21:00 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     ezequiel@...guardiasur.com.ar, p.zabel@...gutronix.de,
        Benjamin Gaignard <benjamin.gaignard@...labora.com>
Cc:     mchehab@...nel.org, nicolas@...fresne.ca, hverkuil-cisco@...all.nl,
        gregkh@...uxfoundation.org, wens@...e.org, samuel@...lland.org,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, linux-staging@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev
Subject: Re: [RFC PATCH 0/8] media: hantro: Add 10-bit support

Dne sreda, 06. april 2022 ob 08:54:07 CEST je Benjamin Gaignard napisal(a):
> Le 05/04/2022 à 20:40, Jernej Škrabec a écrit :
> > Hi Benjamin!
> > 
> > Dne torek, 05. april 2022 ob 18:07:41 CEST je Benjamin Gaignard 
napisal(a):
> >> Le 27/02/2022 à 15:49, Jernej Skrabec a écrit :
> >>> First two patches add 10-bit formats to UAPI, third extends filtering
> >>> mechanism, fourth fixes incorrect assumption, fifth moves register
> >>> configuration code to proper place, sixth and seventh enable 10-bit
> >>> VP9 decoding on Allwinner H6 and last increases core frequency on
> >>> Allwinner H6.
> >>> 
> >>> I'm sending this as RFC to get some comments:
> >>> 1. format definitions - are fourcc's ok? are comments/descriptions ok?
> >>> 2. is extended filtering mechanism ok?
> >>> 
> >>> I would also like if these patches are tested on some more HW.
> >>> Additionally, can someone test tiled P010?
> >>> 
> >>> Please take a look.
> >> 
> >> Hi Jernej,
> >> 
> >> I have create a branch to test this series with VP9 and HEVC:
> >> https://gitlab.collabora.com/benjamin.gaignard/for-upstream/-/tree/10bit_
> >> imx 8m Feel free to pick what I may need in it.
> >> 
> >> That doesn't improve fluster scores, I think more dev are still needed in
> >> GST before getting something fully functional.
> >> Anyway I able to select P010 pixel format if the input is a 10bit
> >> bitstream.> 
> > What kind of improvements do you expect? Actually, this series is designed
> > to change nothing for platforms, where 10-bit format is not added into
> > the list of supported formats. I think reasons are quite obvious. First,
> > not every device may support 10-bit output. Second, as you might already
> > figured it out, registers in this series are set only for legacy cores. I
> > have no idea, what needs to be done for newer ones, since I don't have
> > them. Anyway, I tested this with fluster and only one additional test
> > passes, because it is the only one for 10-bit YUV420.
> 
> In this series you will find that I have added the registers for the new
> cores, fix hevc to be able to use 10-bit, and enable that in IMX8M.

Your changes seems reasonable, but at this point I wouldn't bother with 
fluster. Instead, try to test with one specific bitstream or even a sample video 
file. I just tested with one random 10-bit VP9 video that I found when working 
on this series. That way you avoid any corner cases which sometimes plaque 
fluster testing (reference bitstreams smaller than min. supported size). 
Anyway, re-check vendor lib if there is any other place to adjust something 
for 10-bit.

Best regards,
Jernej

> 
> Regards,
> Benjamin
> 
> > Best regards,
> > Jernej