linux-kernel - Re: linux-next: runtime warning after merge of the cel-fixes tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Apr 2022 10:54:46 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Chuck Lever III <chuck.lever@...cle.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: runtime warning after merge of the cel-fixes tree

On Thu, 7 Apr 2022 13:48:54 +0000
Chuck Lever III <chuck.lever@...cle.com> wrote:

> > event svc_defer_recv has unsafe dereference of argument 1
> > print_fmt: "addr=%pISpc dr=%p xid=0x%08x", (struct sockaddr *)__get_dynamic_array(addr), REC->dr, REC->xid
> > event svc_defer_queue has unsafe dereference of argument 1
> > print_fmt: "addr=%pISpc dr=%p xid=0x%08x", (struct sockaddr *)__get_dynamic_array(addr), REC->dr, REC->xid
> > event svc_defer_drop has unsafe dereference of argument 1
> > print_fmt: "addr=%pISpc dr=%p xid=0x%08x", (struct sockaddr *)__get_dynamic_array(addr), REC->dr, REC->xid
> > NR_IRQS: 512, nr_irqs: 512, preallocated irqs: 16
> > rcu: srcu_init: Setting srcu_struct sizes based on contention.
> > 
> > Introduced by commit
> > 
> >  e2e917f8677d ("SUNRPC: Fix the svc_deferred_event trace class")
> > 
> > At least reverting that commit makes the warning go away.
> > 
> > I have left that commit reverted for today.  
> 
> Thank you, Stephen. The NFS community has already discussed a
> fix for this issue. I'll push it out as soon as I can.

Hmm, I know we added code to handle "__get_sockaddr()" but I guess this
should also be fine for "__get_dynamic_array()" as well.

I could write a patch to cover those too.

-- Steve