linux-kernel - Re: [PATCH] dt-bindings: dma: uniphier: Use unevaluatedProperties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk80eFKwDVnU67p/@robh.at.kernel.org>
Date:   Thu, 7 Apr 2022 13:59:04 -0500
From:   Rob Herring <robh@...nel.org>
To:     Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: uniphier: Use unevaluatedProperties

On Thu, Apr 07, 2022 at 04:44:07PM +0900, Kunihiko Hayashi wrote:
> This refers common bindings, so this is preferred for
> unevaluatedProperties instead of additionalProperties.

Yes and no. If you want to define specific common properties are used 
(and not used), then listing them in the specific schema with 
'additionalProperties' is the right way to do that. If all properties in 
the referenced schema are valid, then unevaluatedProperties is correct.

If we wanted using unevaluatedProperties to be a hard rule, we could 
make the meta-schema enforce that.

> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
> ---
>  .../devicetree/bindings/dma/socionext,uniphier-mio-dmac.yaml    | 2 +-
>  .../devicetree/bindings/dma/socionext,uniphier-xdmac.yaml       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/socionext,uniphier-mio-dmac.yaml b/Documentation/devicetree/bindings/dma/socionext,uniphier-mio-dmac.yaml
> index e7bf6dd7da29..b40f247e07be 100644
> --- a/Documentation/devicetree/bindings/dma/socionext,uniphier-mio-dmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/socionext,uniphier-mio-dmac.yaml
> @@ -45,7 +45,7 @@ required:
>    - clocks
>    - '#dma-cells'
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  examples:
>    - |
> diff --git a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml
> index 371f18773198..b2bd21cbeb7f 100644
> --- a/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml
> +++ b/Documentation/devicetree/bindings/dma/socionext,uniphier-xdmac.yaml
> @@ -40,7 +40,7 @@ properties:
>      minimum: 1
>      maximum: 16
>  
> -additionalProperties: false
> +unevaluatedProperties: false
>  
>  required:
>    - compatible
> -- 
> 2.25.1
> 
>