linux-kernel - Re: [PATCH] dt-bindings: dma: uniphier: Use unevaluatedProperties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f350b1d8-23d5-e13b-d908-0fa02f8fcea5@socionext.com>
Date:   Sat, 9 Apr 2022 01:13:35 +0900
From:   Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Vinod Koul <vkoul@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        dmaengine@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: uniphier: Use unevaluatedProperties

Hi Rob,

On 2022/04/08 3:59, Rob Herring wrote:
> On Thu, Apr 07, 2022 at 04:44:07PM +0900, Kunihiko Hayashi wrote:
>> This refers common bindings, so this is preferred for
>> unevaluatedProperties instead of additionalProperties.
> 
> Yes and no. If you want to define specific common properties are used
> (and not used), then listing them in the specific schema with
> 'additionalProperties' is the right way to do that. If all properties in
> the referenced schema are valid, then unevaluatedProperties is correct.

I understand that having a reference to a common schema isn't a direct reason
to replace with unevaluatedProperties because it depends on how each property
of the common schema is handled in this schema.

Since there is no property to evaluate with "if" etc., I think that it can
be left as "additionalProperties" in this schema.
I withdraw this patch.

> If we wanted using unevaluatedProperties to be a hard rule, we could
> make the meta-schema enforce that.

At the moment it is difficult to decide it to be a hard rule.

Thank you,

---
Best Regards
Kunihiko Hayashi