linux-kernel - Re: [PATCH v1 2/7] md/raid5: Un-nest struct raid5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk/Q2uYnp9jNbjB1@infradead.org>
Date:   Thu, 7 Apr 2022 23:06:18 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Logan Gunthorpe <logang@...tatee.com>
Cc:     linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
        Song Liu <song@...nel.org>,
        Guoqing Jiang <guoqing.jiang@...ux.dev>
Subject: Re: [PATCH v1 2/7] md/raid5: Un-nest struct raid5_percpu definition

On Thu, Apr 07, 2022 at 10:57:08AM -0600, Logan Gunthorpe wrote:
> Sparse reports many warnings of the form:
>   drivers/md/raid5.c:1476:16: warning: dereference of noderef expression
> 
> This is because all struct raid5_percpu definitions get marked as
> __percpu when really only the pointer in r5conf should have that
> annotation.
> 
> Fix this by moving the defnition of raid5_precpu out of the definition
> of struct r5conf.

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>