linux-kernel - Re: [PATCH v1 1/7] md/raid5: Cleanup setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk/Qyo/tAb0Q9xur@infradead.org>
Date:   Thu, 7 Apr 2022 23:06:02 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     Logan Gunthorpe <logang@...tatee.com>
Cc:     linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
        Song Liu <song@...nel.org>,
        Guoqing Jiang <guoqing.jiang@...ux.dev>
Subject: Re: [PATCH v1 1/7] md/raid5: Cleanup setup_conf() error returns

On Thu, Apr 07, 2022 at 10:57:07AM -0600, Logan Gunthorpe wrote:
> Be more careful about the error returns. Most errors in this function
> are actually ENOMEM, but it forcibly returns EIO if conf has been
> allocated.
> 
> Instead return ret and ensure it is set appropriately before each goto
> abort.
> 
> Signed-off-by: Logan Gunthorpe <logang@...tatee.com>

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>