linux-kernel - Re: [PATCH v2 10/10] Documentation: Update the recommended pattern for GPIO irqchips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Apr 2022 14:33:56 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Thierry Reding <thierry.reding@...il.com>,
        Joey Gouly <joey.gouly@....com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Hector Martin <marcan@...can.st>,
        Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Jeffrey Hugo <jeffrey.l.hugo@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Basavaraj Natikar <Basavaraj.Natikar@....com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        linux-arm-msm@...r.kernel.org,
        Android Kernel Team <kernel-team@...roid.com>
Subject: Re: [PATCH v2 10/10] Documentation: Update the recommended pattern
 for GPIO irqchips

On Wed, Apr 6, 2022 at 1:57 PM Marc Zyngier <maz@...nel.org> wrote:
>
> Update the documentation to get rid of the per-gpio_irq_chip
> irq_chip structure, and give examples of the new pattern.

...

> +  static void my_gpio_mask_irq(struct irq_data *d)
> +  {
> +      struct gpio_chip *gc = irq_desc_get_handler_data(d);
> +
> +      /*
> +       * Perform any necessary action to mask the interrupt,
> +       * and then call into the core code to synchronise the
> +       * state.
> +       */
> +
> +      gpiochip_disable_irq(gc, d->hwirq);

(1)

> +  }
> +
> +  static void my_gpio_unmask_irq(struct irq_data *d)
> +  {
> +      struct gpio_chip *gc = irq_desc_get_handler_data(d);

> +      gpiochip_disable_irq(gc, d->hwirq);

(2)

> +      /*
> +       * Perform any necessary action to unmask the interrupt,
> +       * after having called into the core code to synchronise
> +       * the state.
> +       */
> +  }

If (1) and (2) being the same is not a mistake (typo) it probably
needs additional explanation.

...

> +  static void my_gpio_mask_irq(struct irq_data *d)
> +  {
> +      struct gpio_chip *gc = irq_desc_get_handler_data(d);
> +
> +      /*
> +       * Perform any necessary action to mask the interrupt,
> +       * and then call into the core code to synchronise the
> +       * state.
> +       */

> +      gpiochip_disable_irq(gc, d->hwirq);

(3)

> +  }
> +
> +  static void my_gpio_unmask_irq(struct irq_data *d)
> +  {
> +      struct gpio_chip *gc = irq_desc_get_handler_data(d);

> +      gpiochip_disable_irq(gc, d->hwirq);

(4)

> +      /*
> +       * Perform any necessary action to unmask the interrupt,
> +       * after having called into the core code to synchronise
> +       * the state.
> +       */
> +  }

Ditto for (3) & (4).

...

> +  static void my_gpio_mask_irq(struct irq_data *d)
> +  {
> +      struct gpio_chip *gc = irq_desc_get_handler_data(d);
> +
> +      /*
> +       * Perform any necessary action to mask the interrupt,
> +       * and then call into the core code to synchronise the
> +       * state.
> +       */
> +
> +      gpiochip_disable_irq(gc, d->hwirq);

(5)

> +      irq_mask_mask_parent(d);
> +  }
> +
> +  static void my_gpio_unmask_irq(struct irq_data *d)
> +  {
> +      struct gpio_chip *gc = irq_desc_get_handler_data(d);

> +      gpiochip_disable_irq(gc, d->hwirq);

(6)

> +      /*
> +       * Perform any necessary action to unmask the interrupt,
> +       * after having called into the core code to synchronise
> +       * the state.
> +       */
> +
> +      irq_mask_unmask_parent(d);
> +  }

Ditto for (5) & (6).

--
With Best Regards,
Andy Shevchenko