linux-kernel - Re: [PATCH 13/18] dt-bindings: fix jz4780-nemc issue as reported by dtbscheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <VDO2AR.XO9112UD3KYT3@crapouillou.net>
Date:   Sat, 09 Apr 2022 13:37:07 +0100
From:   Paul Cercueil <paul@...pouillou.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     "H. Nikolaus Schaller" <hns@...delico.com>,
        Rob Herring <robh+dt@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH 13/18] dt-bindings: fix jz4780-nemc issue as reported by
 dtbscheck

Hi Krzysztof,

Le sam., avril 9 2022 at 13:26:25 +0200, Krzysztof Kozlowski 
<krzysztof.kozlowski@...aro.org> a écrit :
> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>>  jz4780-nemc needs to be compatible to simple-mfd as well or we get
>> 
>>  arch/mips/boot/dts/ingenic/ci20.dtb: memory-controller@...10000: 
>> compatible: 'oneOf' conditional failed, one must be fixed:
>>  	['ingenic,jz4780-nemc', 'simple-mfd'] is too long
>>  	'ingenic,jz4725b-nemc' was expected
>>  	'ingenic,jz4740-nemc' was expected
>>  	From schema: 
>> Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
>> 
>>  Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>>  ---
>>   .../devicetree/bindings/memory-controllers/ingenic,nemc.yaml    | 
>> 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>>  diff --git 
>> a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml 
>> b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
>>  index 24f9e19820282..3b1116588de3d 100644
>>  --- 
>> a/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
>>  +++ 
>> b/Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.yaml
>>  @@ -17,7 +17,7 @@ properties:
>>       oneOf:
>>         - enum:
>>             - ingenic,jz4740-nemc
>>  -          - ingenic,jz4780-nemc
>>  +          - [ ingenic,jz4780-nemc, simple-mfd ]
> 
> This is not correct representation. If you really need simple-mfd, 
> then
> this should be a separate item below oneOf.

Correct.

> The true question is whether you need simple-mfd. Isn't the binding 
> (and
> the driver) expected to instantiate its children?

I can explain that one. There is the EFUSE controller located inside 
the nemc's memory area, and the two are pretty much unrelated, hence 
the "simple-mfd" compatible string.

Cheers,
-Paul