linux-kernel - Re: [PATCH 03/18] MIPS: DTS: jz4780: fix tcu timer as reported by dtbscheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 9 Apr 2022 14:38:39 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     "H. Nikolaus Schaller" <hns@...delico.com>,
        Rob Herring <robh+dt@...nel.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH 03/18] MIPS: DTS: jz4780: fix tcu timer as reported by
 dtbscheck

On 09/04/2022 14:24, Paul Cercueil wrote:
> Hi Krzysztof,
> 
> Le sam., avril 9 2022 at 13:11:48 +0200, Krzysztof Kozlowski 
> <krzysztof.kozlowski@...aro.org> a écrit :
>> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>>>  arch/mips/boot/dts/ingenic/ci20.dtb: timer@...02000: compatible: 
>>> 'oneOf' conditional failed, one must be fixed:
>>>  	['ingenic,jz4780-tcu', 'ingenic,jz4770-tcu', 'simple-mfd'] is too 
>>> long
>>>  	'ingenic,jz4780-tcu' is not one of ['ingenic,jz4740-tcu', 
>>> 'ingenic,jz4725b-tcu', 'ingenic,jz4760-tcu', 'ingenic,x1000-tcu']
>>>  	'simple-mfd' was expected
>>>  	'ingenic,jz4760-tcu' was expected
>>
>> Trim it a bit...
>>
>>>  	From schema: 
>>> Documentation/devicetree/bindings/timer/ingenic,tcu.yaml
>>
>> You need to explain this. You're changing the effective compatible of
>> the device and doing so based only on schema warning does not look
>> enough. Please write real reason instead of this fat warning, e.g. 
>> that
>> both devices are actually compatible and this has no real effect 
>> except
>> schema checks.
> 
> Well, if the schema says that it should use a particular fallback 
> string, then that's what the DTS should use, right?

Or the schema is wrong. :)

> If making the DTS schema-compliant causes breakages, then that means 
> the schema is wrong and should be fixed.

Exactly, so the commit needs a bit of explanation why one solution was
chosen over the other. BTW, I am not saying that schema or DTS is wrong,
just that commit is not explained enough.

Best regards,
Krzysztof