linux-kernel - Re: [PATCH 05/18] MIPS: DTS: jz4780: fix pinctrl as reported by dtbscheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c84b5ec0-0193-ab62-1985-25bc2baa9f05@linaro.org>
Date:   Sat, 9 Apr 2022 15:13:54 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Paul Cercueil <paul@...pouillou.net>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH 05/18] MIPS: DTS: jz4780: fix pinctrl as reported by
 dtbscheck

On 09/04/2022 15:04, H. Nikolaus Schaller wrote:
> 
> 
>> Am 09.04.2022 um 13:13 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>:
>>
>> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>>> arch/mips/boot/dts/ingenic/ci20.dtb: pin-controller@...10000: $nodename:0: 'pin-controller@...10000' does not match '^(pinctrl|pinmux)(@[0-9a-f]+)?$'
>>> 	From schema: Documentation/devicetree/bindings/pinctrl/ingenic,pinctrl.yaml
>>>
>>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
>>> ---
>>> arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> index 5f44cf004d473..b5299eaffb84a 100644
>>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> @@ -155,7 +155,7 @@ rtc_dev: rtc@...03000 {
>>> 		clock-names = "rtc";
>>> 	};
>>>
>>> -	pinctrl: pin-controller@...10000 {
>>> +	pinctrl: pinctrl@...10000 {
>>
>> Do it once for all DTSes, not one file at a time. There are four more
>> places with this.
> 
> Well, automation has no notion of "similarity" in this case to
> merge several patches.

What does that mean? One cannot create multiple patches and apply them?

> And they are not related. Every one is based on a different .yaml
> schema file.

Which does not matter, because the name of the node does not matter. We
enforce it in schema to makes things organized and easier in testing.
This does not fix any real problem, just the problem we created by
ourselves with schema.

> 
> That in all cases the result looks similar comes from similar
> requirements by the schemata and has no inherent connection.

All schemas will require it, won't they? The same for arm...

Best regards,
Krzysztof