linux-kernel - Re: [PATCH 07/18] MIPS: DTS: jz4780: fix otg node as reported by dtbscheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <535e3eab-a28e-46f3-2a7e-f1ffd1913470@linaro.org>
Date:   Sat, 9 Apr 2022 15:15:32 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "H. Nikolaus Schaller" <hns@...delico.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Paul Cercueil <paul@...pouillou.net>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH 07/18] MIPS: DTS: jz4780: fix otg node as reported by
 dtbscheck

On 09/04/2022 15:05, H. Nikolaus Schaller wrote:
>>
>> This looks wrong, the block usually should have a specific compatible.
>> Please mention why it does not.
> 
> Well, I did not even have that idea that it could need an explanation.
> 
> There is no "ingenic,jz4780-otg" and none is needed here to make it work.

Make it work in what terms? We talk about hardware description, right?

> 
> Therefore the generic "snps,dwc2" is sufficient.

No, you are mixing now driver behavior (is sufficient) with hardware
description. Most of licensed blocks require the specific compatible to
differentiate it.


Best regards,
Krzysztof