linux-kernel - Re: [PATCH 10/18] MIPS: DTS: jz4780: fix uart dmas as reported by dtbscheck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <5F7268BB-CCF3-4F01-ABB9-D5C3319F31F1@goldelico.com>
Date:   Sat, 9 Apr 2022 15:26:36 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Paul Cercueil <paul@...pouillou.net>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-mips@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH 10/18] MIPS: DTS: jz4780: fix uart dmas as reported by
 dtbscheck



> Am 09.04.2022 um 15:16 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>:
> 
> On 09/04/2022 15:07, H. Nikolaus Schaller wrote:
>> 
>> 
>>> Am 09.04.2022 um 13:18 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>:
>>> 
>>> On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@...30000: 'dmas' is a required property
>>>> 	From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@...30000: 'dma-names' is a required property
>>>> 	From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@...31000: 'dmas' is a required property
>>>> 	From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@...31000: 'dma-names' is a required property
>>>> 	From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@...32000: 'dmas' is a required property
>>>> 	From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@...32000: 'dma-names' is a required property
>>>> 	From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@...33000: 'dmas' is a required property
>>>> 	From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@...33000: 'dma-names' is a required property
>>>> 	From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@...34000: 'dmas' is a required property
>>>> 	From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: serial@...34000: 'dma-names' is a required property
>>>> 	From schema: Documentation/devicetree/bindings/serial/ingenic,uart.yaml
>>>> arch/mips/boot/dts/ingenic/ci20.dtb: i2c@...50000: 'dmas' is a required property
>>> 
>>> All these warnings are the same two warnings...
>> 
>> See my earlier explanation that without them you can't verify by just reading commit message
>> and diff that all existing warnings have been addressed.
> 
> Which does not make sense and there is no need... Automation does it
> (see Rob's tools). Don't make human life more difficult...

Ok, you are right. If you apply this patch and then run dtbscheck again, there would be
a warning left over.

But may I honestly ask why you review the commits and read the commit message at all?
You could simply ignore it... And it would be easier for both of us to leave it completely
to Rob's tools :)

BR and thanks,
Nikolaus