linux-kernel - Re: [PATCH] macintosh: fix via-pmu and via-cuda build without RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9cda10ff-7daa-808e-477f-6b9c4e0445d9@infradead.org>
Date:   Sun, 10 Apr 2022 09:05:36 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     kernel test robot <lkp@...el.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>,
        Finn Thain <fthain@...ux-m68k.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH] macintosh: fix via-pmu and via-cuda build without
 RTC_CLASS

Hi--

On 4/10/22 00:03, Christophe Leroy wrote:
> 
> 
> Le 09/04/2022 à 04:08, Randy Dunlap a écrit :
>> Fix build when RTC_CLASS is not set/enabled.
>> Eliminates these build errors:
>>
>> m68k-linux-ld: drivers/macintosh/via-pmu.o: in function `pmu_set_rtc_time':
>> drivers/macintosh/via-pmu.c:1769: undefined reference to `rtc_tm_to_time64'
>> m68k-linux-ld: drivers/macintosh/via-cuda.o: in function `cuda_set_rtc_time':
>> drivers/macintosh/via-cuda.c:797: undefined reference to `rtc_tm_to_time64'
> 
> You don't need RTC_CLASS for that. All you need is RTC_LIB I think.

Oh good.

> What about selecting RTC_LIB from m68k Kconfig just like powerpc and a 
> few architectures do ?

Sounds good. I'll test that now.

> See 
> https://elixir.bootlin.com/linux/v5.18-rc1/source/arch/powerpc/Kconfig#L269
> 
> Otherwise, I think it would be better to move (and rename) 
> rtc_tm_to_time64() into kernel/time/time.c instead of opencoding it twice.
> 

Yeah, I didn't like that either.

>>
>> Fixes: 0792a2c8e0bb ("macintosh: Use common code to access RTC")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
>> Cc: Michael Ellerman <mpe@...erman.id.au>
>> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
>> Cc: Kees Cook <keescook@...omium.org>
>> Cc: Arnd Bergmann <arnd@...db.de>
>> Cc: Finn Thain <fthain@...ux-m68k.org>
>> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Cc: Nathan Chancellor <nathan@...nel.org>
>> Cc: Nick Desaulniers <ndesaulniers@...gle.com>
>> Cc: linuxppc-dev@...ts.ozlabs.org
>> ---
>>   drivers/macintosh/via-cuda.c |    5 ++++-
>>   drivers/macintosh/via-pmu.c  |    5 ++++-
>>   2 files changed, 8 insertions(+), 2 deletions(-)

thanks.
-- 
~Randy