linux-kernel - Re: [PATCH] macintosh: fix via-pmu and via-cuda build without RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ae85daa9-97a4-3ed2-5692-0d4545a88b58@csgroup.eu>
Date:   Sun, 10 Apr 2022 07:03:13 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     kernel test robot <lkp@...el.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Kees Cook <keescook@...omium.org>,
        Arnd Bergmann <arnd@...db.de>,
        Finn Thain <fthain@...ux-m68k.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH] macintosh: fix via-pmu and via-cuda build without
 RTC_CLASS



Le 09/04/2022 à 04:08, Randy Dunlap a écrit :
> Fix build when RTC_CLASS is not set/enabled.
> Eliminates these build errors:
> 
> m68k-linux-ld: drivers/macintosh/via-pmu.o: in function `pmu_set_rtc_time':
> drivers/macintosh/via-pmu.c:1769: undefined reference to `rtc_tm_to_time64'
> m68k-linux-ld: drivers/macintosh/via-cuda.o: in function `cuda_set_rtc_time':
> drivers/macintosh/via-cuda.c:797: undefined reference to `rtc_tm_to_time64'

You don't need RTC_CLASS for that. All you need is RTC_LIB I think.

What about selecting RTC_LIB from m68k Kconfig just like powerpc and a 
few architectures do ?

See 
https://elixir.bootlin.com/linux/v5.18-rc1/source/arch/powerpc/Kconfig#L269

Otherwise, I think it would be better to move (and rename) 
rtc_tm_to_time64() into kernel/time/time.c instead of opencoding it twice.

Christophe


> 
> Fixes: 0792a2c8e0bb ("macintosh: Use common code to access RTC")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Christophe Leroy <christophe.leroy@...roup.eu>
> Cc: Kees Cook <keescook@...omium.org>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Finn Thain <fthain@...ux-m68k.org>
> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Nathan Chancellor <nathan@...nel.org>
> Cc: Nick Desaulniers <ndesaulniers@...gle.com>
> Cc: linuxppc-dev@...ts.ozlabs.org
> ---
>   drivers/macintosh/via-cuda.c |    5 ++++-
>   drivers/macintosh/via-pmu.c  |    5 ++++-
>   2 files changed, 8 insertions(+), 2 deletions(-)
> 
> --- a/drivers/macintosh/via-cuda.c
> +++ b/drivers/macintosh/via-cuda.c
> @@ -794,7 +794,10 @@ int cuda_set_rtc_time(struct rtc_time *t
>   	u32 now;
>   	struct adb_request req;
>   
> -	now = lower_32_bits(rtc_tm_to_time64(tm) + RTC_OFFSET);
> +	now = lower_32_bits(mktime64(((unsigned int)tm->tm_year + 1900),
> +			    tm->tm_mon + 1, tm->tm_mday, tm->tm_hour,
> +			    tm->tm_min, tm->tm_sec)
> +			    + RTC_OFFSET);
>   	if (cuda_request(&req, NULL, 6, CUDA_PACKET, CUDA_SET_TIME,
>   	                 now >> 24, now >> 16, now >> 8, now) < 0)
>   		return -ENXIO;
> --- a/drivers/macintosh/via-pmu.c
> +++ b/drivers/macintosh/via-pmu.c
> @@ -1766,7 +1766,10 @@ int pmu_set_rtc_time(struct rtc_time *tm
>   	u32 now;
>   	struct adb_request req;
>   
> -	now = lower_32_bits(rtc_tm_to_time64(tm) + RTC_OFFSET);
> +	now = lower_32_bits(mktime64(((unsigned int)tm->tm_year + 1900),
> +			    tm->tm_mon + 1, tm->tm_mday, tm->tm_hour,
> +			    tm->tm_min, tm->tm_sec)
> +			    + RTC_OFFSET);
>   	if (pmu_request(&req, NULL, 5, PMU_SET_RTC,
>   	                now >> 24, now >> 16, now >> 8, now) < 0)
>   		return -ENXIO;