linux-kernel - Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <783d850ce7778e9d8f203155034e432910553b1b.camel@perches.com>
Date:   Sun, 10 Apr 2022 10:07:58 -0700
From:   Joe Perches <joe@...ches.com>
To:     Vihas Makwana <makvihas@...il.com>,
        Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Pavel Skripkin <paskripkin@...il.com>
Subject: Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper
 rtw_free_cmd_priv

On Sun, 2022-04-10 at 22:01 +0530, Vihas Makwana wrote:
> Remove the unnecessary wrapper. The logic of rtw_free_cmd_priv can
> be moved to _rtw_free_cmd_priv.

If you are going to drop wrappers, my preference would be
to drop the underscore prefixed ones.