lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 10 Apr 2022 23:08:02 +0530
From:   Vihas Makwana <makvihas@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Dan Carpenter <dan.carpenter@...cle.com>,
        Pavel Skripkin <paskripkin@...il.com>
Subject: Re: [PATCH 1/6] staging: r8188eu: drop unnecessary wrapper rtw_free_cmd_priv

> On Sun, 2022-04-10 at 22:01 +0530, Vihas Makwana wrote:
> > Remove the unnecessary wrapper. The logic of rtw_free_cmd_priv can
> > be moved to _rtw_free_cmd_priv.
>
> If you are going to drop wrappers, my preference would be
> to drop the underscore prefixed ones.
>
Yes, that was my initial thought too. But there are already some init
and free functions in the module with underscores prefixed.
So I didn't do it that way. Maybe the developers kept it that way for
some reason.


On Sun, Apr 10, 2022 at 10:38 PM Joe Perches <joe@...ches.com> wrote:
>
> On Sun, 2022-04-10 at 22:01 +0530, Vihas Makwana wrote:
> > Remove the unnecessary wrapper. The logic of rtw_free_cmd_priv can
> > be moved to _rtw_free_cmd_priv.
>
> If you are going to drop wrappers, my preference would be
> to drop the underscore prefixed ones.
>
>


--
Thanks,
Vihas

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ