linux-kernel - Re: [Patch v6 3/4] dt-bindings: memory: Update reg maxitems for tegra186

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57825f4a-8cfa-ef00-6462-fea37cd4d7be@collabora.com>
Date:   Mon, 11 Apr 2022 18:29:05 +0300
From:   Dmitry Osipenko <dmitry.osipenko@...labora.com>
To:     Ashish Mhetre <amhetre@...dia.com>,
        Dmitry Osipenko <digetx@...il.com>,
        krzysztof.kozlowski@...aro.org, thierry.reding@...il.com,
        jonathanh@...dia.com, robh+dt@...nel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-tegra@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org
Cc:     vdumpa@...dia.com, Snikam@...dia.com
Subject: Re: [Patch v6 3/4] dt-bindings: memory: Update reg maxitems for
 tegra186

On 4/11/22 18:02, Ashish Mhetre wrote:
> 
> 
> On 4/10/2022 7:51 PM, Dmitry Osipenko wrote:
>> External email: Use caution opening links or attachments
>>
>>
>> 06.04.2022 08:24, Ashish Mhetre пишет:
>>>           memory-controller@...0000 {
>>>               compatible = "nvidia,tegra186-mc";
>>> -            reg = <0x0 0x02c00000 0x0 0xb0000>;
>>> +            reg = <0x0 0x02c00000 0x0 0x10000>,    /* MC-SID */
>>> +                  <0x0 0x02c10000 0x0 0x10000>,    /* Broadcast
>>> channel */
>>> +                  <0x0 0x02c20000 0x0 0x10000>,    /* MC0 */
>>> +                  <0x0 0x02c30000 0x0 0x10000>,    /* MC1 */
>>> +                  <0x0 0x02c40000 0x0 0x10000>,    /* MC2 */
>>> +                  <0x0 0x02c50000 0x0 0x10000>;    /* MC3 */
>>> +            reg-names = "mc-sid", "mc-broadcast", "mc0", "mc1",
>>> "mc2", "mc3";
>>
>> The "mc-" prefix feels redundant to me, I'd name the regs like this:
>>
>>    "sid", "broadcast", "ch0", "ch1", "ch2", "ch3"
>>
>>
>> You should also add validation of the regs/reg-names to the yaml based
>> on SoC version. I.e. it's not enough to only bump the maxItems.
> 
> Okay, I will add validation of reg-names as following:
> 
>   reg-names:
>     minItems: 0
>     maxItems: 6
>     items:
>       - const: sid
>       - const: broadcast
>       - const: ch0
>       - const: ch1
>       - const: ch2
>       - const: ch3
> 
> 
> We will have to keep minItems to 0 in order to make it compatible with
> old DT, right?

Bindings are about the latest DTs. In general older dtbs must be updated
and you must get error from the schema checker for older DTs. It's only
drivers that should care about older dtbs.