linux-kernel - Re: [PATCH] perf tools: Fix misleading add event pmu debug message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YlRshf1/FVSaQEXJ@kernel.org>
Date:   Mon, 11 Apr 2022 14:59:33 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Adrian Hunter <adrian.hunter@...el.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, Ian Rogers <irogers@...gle.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fix misleading add event pmu debug message

Em Mon, Apr 11, 2022 at 09:17:58AM +0300, Adrian Hunter escreveu:
> Fix incorrect debug message:
> 
>    Attempting to add event pmu 'intel_pt' with '' that may result in
>    non-fatal errors
> 
> which always appears with perf record -vv and intel_pt e.g.
> 
>     perf record -vv -e intel_pt//u uname
> 
> The message is incorrect because there will never be non-fatal errors.
> 
> Suppress the message if the pmu is 'selectable' i.e. meant to be selected
> directly as an event.

Thanks, applied.

- Arnaldo

 
> Fixes: 4ac22b484d4c79 ("perf parse-events: Make add PMU verbose output clearer")
> Signed-off-by: Adrian Hunter <adrian.hunter@...el.com>
> ---
>  tools/perf/util/parse-events.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 24997925ae00..dd84fed698a3 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -1523,7 +1523,9 @@ int parse_events_add_pmu(struct parse_events_state *parse_state,
>  	bool use_uncore_alias;
>  	LIST_HEAD(config_terms);
>  
> -	if (verbose > 1) {
> +	pmu = parse_state->fake_pmu ?: perf_pmu__find(name);
> +
> +	if (verbose > 1 && !(pmu && pmu->selectable)) {
>  		fprintf(stderr, "Attempting to add event pmu '%s' with '",
>  			name);
>  		if (head_config) {
> @@ -1536,7 +1538,6 @@ int parse_events_add_pmu(struct parse_events_state *parse_state,
>  		fprintf(stderr, "' that may result in non-fatal errors\n");
>  	}
>  
> -	pmu = parse_state->fake_pmu ?: perf_pmu__find(name);
>  	if (!pmu) {
>  		char *err_str;
>  
> -- 
> 2.25.1

-- 

- Arnaldo