linux-kernel - Re: [PATCH v4 RESEND 9/9] serial: atmel: remove redundant assignment in rs485_config

Open Source and information security mailing list archives

Message-ID: <4d301703-bca1-8bda-c66a-ae53890ddac9@microchip.com>
Date:   Mon, 11 Apr 2022 08:27:55 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <LinoSanfilippo@....de>, <gregkh@...uxfoundation.org>,
        <jirislaby@...nel.org>, <u.kleine-koenig@...gutronix.de>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <alexandre.belloni@...tlin.com>, <mcoquelin.stm32@...il.com>,
        <richard.genoud@...il.com>, <festevam@...il.com>,
        <s.hauer@...gutronix.de>, <linux@...linux.org.uk>,
        <alexandre.torgue@...s.st.com>, <Ludovic.Desroches@...rochip.com>,
        <lukas@...ner.de>, <linux-imx@....com>, <kernel@...gutronix.de>,
        <linux-serial@...r.kernel.org>, <shawnguo@...nel.org>,
        <linux-stm32@...md-mailman.stormreply.com>,
        <linux-kernel@...r.kernel.org>, <p.rosenberger@...bus.com>
Subject: Re: [PATCH v4 RESEND 9/9] serial: atmel: remove redundant assignment
 in rs485_config

On 10.04.2022 13:46, Lino Sanfilippo wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> In uart_set_rs485_config() the serial core already assigns the passed
> serial_rs485 struct to the uart port.
> 
> So remove the assignment from the drivers rs485_config() function to avoid
> redundancy.
> 
> Acked-by: Richard Genoud <richard.genoud@...il.com>
> Signed-off-by: Lino Sanfilippo <LinoSanfilippo@....de>

Reviewed-by: Claudiu Beznea <claudiu.beznea@...rochip.com>


> ---
>  drivers/tty/serial/atmel_serial.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index 3a45e4fc7993..dd1c7e4bd1c9 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -299,11 +299,9 @@ static int atmel_config_rs485(struct uart_port *port,
>         /* Resetting serial mode to RS232 (0x0) */
>         mode &= ~ATMEL_US_USMODE;
> 
> -       port->rs485 = *rs485conf;
> -
>         if (rs485conf->flags & SER_RS485_ENABLED) {
>                 dev_dbg(port->dev, "Setting UART to RS485\n");
> -               if (port->rs485.flags & SER_RS485_RX_DURING_TX)
> +               if (rs485conf->flags & SER_RS485_RX_DURING_TX)
>                         atmel_port->tx_done_mask = ATMEL_US_TXRDY;
>                 else
>                         atmel_port->tx_done_mask = ATMEL_US_TXEMPTY;
> --
> 2.35.1
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives