linux-kernel - Re: Move RS485 implementation from drivers to serial core (v4 RESEND)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220920114331.GA26352@wunner.de>
Date:   Tue, 20 Sep 2022 13:43:31 +0200
From:   Lukas Wunner <lukas@...ner.de>
To:     Lino Sanfilippo <LinoSanfilippo@....de>
Cc:     gregkh@...uxfoundation.org, jirislaby@...nel.org,
        u.kleine-koenig@...gutronix.de, linux@...linux.org.uk,
        richard.genoud@...il.com, nicolas.ferre@...rochip.com,
        alexandre.belloni@...tlin.com, ludovic.desroches@...rochip.com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, mcoquelin.stm32@...il.com,
        alexandre.torgue@...s.st.com, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-stm32@...md-mailman.stormreply.com, p.rosenberger@...bus.com
Subject: Re: Move RS485 implementation from drivers to serial core (v4 RESEND)

On Sun, Apr 10, 2022 at 12:46:33PM +0200, Lino Sanfilippo wrote:
> This patch series is an attempt to simplify rs485 implementation in drivers
> by moving the following tasks out of the drivers into the serial core:
> 
> - ensure sane RTS settings: in case of an invalid configuration (both RTS
>   after send and RTS on send set or both unset) enable RTS on send and
>   disable RTS after send
[...]
> Redundant code has been removed from the following drivers for now:
> 
> - atmel
> - fsl_lpuart
> - amba
> - imx
> - max310x
> - omap-serial
> - sc16is7xx
> - stm32-usart

It looks like there's more of this cruft left at least in
serial8250_em485_config()...

Thanks,

Lukas